acuteaura commented on PR #2139: URL: https://github.com/apache/apisix-ingress-controller/pull/2139#issuecomment-1897995842
The test failing is code I didn't touch, which is just an unstable test, it seems to be iterating over a map with two elements and not accounting for map iteration order not being stable. > The iteration order over maps is not specified and is not guaranteed to be the same from one iteration to the next. https://go.dev/ref/spec#RangeClause The range over map is here: https://github.com/acuteaura/apisix-ingress-controller/blob/refactor/root-context-signaling/pkg/types/labels.go#L45 Should go into another PR, and I'd be happy to rebase on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
