shreemaan-abhishek commented on code in PR #10950:
URL: https://github.com/apache/apisix/pull/10950#discussion_r1574556455
##########
apisix/discovery/nacos/schema.lua:
##########
@@ -54,6 +54,49 @@ return {
},
access_key = {type = 'string', default = ''},
secret_key = {type = 'string', default = ''},
+ others = {
Review Comment:
what does this `others` mean?
This looks like a very big PR now. Please explain this PR as a proposal in
#10799, we need to have a consensus on "HOW" to implement this feature.
If we continue to review code without agreeing on "HOW" there will be a lot
of back and forth during reviews and a lot of time wasted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
