ShenFeng312 commented on code in PR #10950:
URL: https://github.com/apache/apisix/pull/10950#discussion_r1575521831
##########
apisix/discovery/nacos/schema.lua:
##########
@@ -54,6 +54,49 @@ return {
},
access_key = {type = 'string', default = ''},
secret_key = {type = 'string', default = ''},
+ others = {
Review Comment:
The 'others' field represents a list of additional Nacos configurations.
Since the previous schema for Nacos configuration was an object, directly
changing it to an array would render existing configurations incompatible.
Therefore, I've utilized the 'others' field to extend this functionality. Of
course, if we decide that backward compatibility is not necessary, we can
redesign this configuration schema. Currently, my implementation involves
adding a new layer of 'nacosName' within the original 'applications' map. This
layer corresponds to different Nacos configurations. Additionally, the
asynchronous tasks for fetching Nacos configurations have been modified from
fetching from a single Nacos instance to fetching from multiple instances. They
are organized into different maps based on the 'name' specified in the
configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
