shreemaan-abhishek commented on code in PR #11172:
URL: https://github.com/apache/apisix/pull/11172#discussion_r1577959393
##########
t/router/radixtree-sni2.t:
##########
@@ -820,3 +820,32 @@ location /t {
}
--- response_body
ssl handshake: true
+
+
+
+=== TEST 22: set ssl conf with secret ref: ENV
+--- request
+GET /t
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ -- set ssl
+ local code, body = t('/apisix/admin/ssls/1',
+ ngx.HTTP_PUT,
+ [[{
+ "cert": "$ENV://TEST_ENV_SSL_CRT",
+ "key": "$ENV://TEST_ENV_SSL_KEY",
+ "sni": "test2.com"
+ }]]
+ )
+ if code >= 300 then
+ ngx.status = code
+ return ngx.say(body)
+ end
+
+ ngx.say("passed")
+ }
+ }
+--- response_body
+passed
Review Comment:
this test proves that using UPPERCASE works, now please add another test
that shows this SSL resource in action (and that the env vars are being
resolved)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
