shreemaan-abhishek commented on PR #11172: URL: https://github.com/apache/apisix/pull/11172#issuecomment-2078500177
@LinkinStars I think using lowercase "`$env://`" and uppercase "`$SECRET://`" might still not work as the code hardcodes the case for sanity checks: Hardcoding for secret reference: https://github.com/shreemaan-abhishek/apisix/blob/07b3cc3f63db8fc4ae3706baa324a76ee3049338/apisix/secret.lua#L34 https://github.com/shreemaan-abhishek/apisix/blob/07b3cc3f63db8fc4ae3706baa324a76ee3049338/apisix/secret.lua#L121 Hardcoding for env reference: https://github.com/shreemaan-abhishek/apisix/blob/07b3cc3f63db8fc4ae3706baa324a76ee3049338/apisix/core/env.lua#L30 https://github.com/shreemaan-abhishek/apisix/blob/07b3cc3f63db8fc4ae3706baa324a76ee3049338/apisix/core/env.lua#L70 If you were to write test cases covering the above situation it would fail. What could be a good solution for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
