acuteaura commented on PR #2236: URL: https://github.com/apache/apisix-ingress-controller/pull/2236#issuecomment-2112240614
okay, sorry, i should've been more clear. the leader status is never lost, and that's the problem. the controller holds on to it indefinitely, even though it really shouldn't. you can keep this bit of code and then call `rootCancel` after `run` is invoked [here](https://github.com/apache/apisix-ingress-controller/blob/d513e59a03c37c16fa62b44d50dbedb21b57e46a/pkg/providers/controller.go#L186), because that controller should never be returning when there's no error or the context is cancelled, and the context that keeps the leader election loop alive is derived from it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
