acuteaura commented on PR #2236: URL: https://github.com/apache/apisix-ingress-controller/pull/2236#issuecomment-2114417032
Hm, I hadn't considered that the process also calls `run` and starts all the controller when it's not leader, so you're probably better off just hard-exiting instead of cancelling the context, because a follower node would never hit OnStoppedLeading. This will leave you with no leader until the lease expires, which is short enough (?!) so it shouldn't be a problem (it's essentially a "pod vanishes without trace" reenactment for the failover). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
