bzp2010 commented on code in PR #11343: URL: https://github.com/apache/apisix/pull/11343#discussion_r1632214492
########## conf/config-default.yaml: ########## @@ -1,690 +0,0 @@ -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# -# CAUTION: DO NOT MODIFY DEFAULT CONFIGURATIONS IN THIS FILE. -# Keep the custom configurations in conf/config.yaml. -# - -apisix: Review Comment: I think this is better, but would it be better to name it something like `config.yaml.example` as it is long and not easy to find what is needed. This way, we will provide a few minimal default configuration files, `config.yaml`, and an example file containing all the configuration documentation, and if the user wants to use the full configuration file, he can replace `config.yaml` with `config.yaml.example`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
