shreemaan-abhishek commented on code in PR #11343:
URL: https://github.com/apache/apisix/pull/11343#discussion_r1633013628
##########
conf/config-default.yaml:
##########
Review Comment:
since the default.yaml file is removed now, should we specify all
configurable parameters in config.yaml as yaml comments?
##########
t/core/etcd-mtls.t:
##########
@@ -82,12 +82,8 @@ deployment:
}
--- request
GET /t
---- grep_error_log eval
-qr/init_by_lua:\d+: \S+/
---- grep_error_log_out
-init_by_lua:12: ab
Review Comment:
why did you remove these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
