lucasarnulphy commented on code in PR #11445:
URL: https://github.com/apache/apisix/pull/11445#discussion_r1699940445
##########
apisix/plugins/cas-auth.lua:
##########
@@ -87,6 +89,9 @@ local function with_session_id(conf, ctx, session_id)
else
-- refresh the TTL
store:set(session_id, user, SESSION_LIFETIME)
+ if conf.set_user_header then
Review Comment:
I'm fine with removing `set_user_header`, and having `user_header` empty by
default.
As far as `send_headers` is concerned, I'm not sure I understand what you
mean.
Do you mean allowing the plugin to put in a header any value from the cas
response ? Because that would require a lot more work as currently only the
user is stored.
Or do you mean having a general array which we can search in in the code
when other headers are implemented ? because that would remove the ability to
overwrite the headers names, which would make it painful to integrate with some
apps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
