shreemaan-abhishek commented on code in PR #11351:
URL: https://github.com/apache/apisix/pull/11351#discussion_r1703107968


##########
apisix/plugins/ocsp-stapling.lua:
##########
@@ -166,6 +179,7 @@ local function set_cert_and_key(sni, value)
     end
 
     local ok, err = set_ocsp_resp(fin_pem_cert,
+                                  value.ocsp_stapling.ssl_stapling_responder,

Review Comment:
   yes but instead of passing this values through mulitple functions, I think a 
simple check before hand can avoid this and make code simpler.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to