shreemaan-abhishek commented on code in PR #11351:
URL: https://github.com/apache/apisix/pull/11351#discussion_r1775125332
##########
apisix/plugins/ocsp-stapling.lua:
##########
@@ -46,25 +46,34 @@ function _M.check_schema(conf)
end
-local function fetch_ocsp_resp(der_cert_chain)
- core.log.info("fetch ocsp response from remote")
- local ocsp_url, err =
ngx_ocsp.get_ocsp_responder_from_der_chain(der_cert_chain)
-
- if not ocsp_url then
+local function get_ocsp_responder(der_cert_chain)
Review Comment:
can we skip this unnecessary function name modification/breaking down of one
function into two?
I am not a OCSP expert and it makes difficult to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
