shreemaan-abhishek commented on code in PR #11451:
URL: https://github.com/apache/apisix/pull/11451#discussion_r1774785818
##########
apisix/plugins/openid-connect.lua:
##########
@@ -290,7 +291,8 @@ local _M = {
}
-function _M.check_schema(conf)
+function _M.check_schema(plugin_conf)
+ local conf = fetch_secrets(plugin_conf)
Review Comment:
this is not needed.
##########
apisix/plugins/openid-connect.lua:
##########
@@ -471,7 +473,7 @@ local function required_scopes_present(required_scopes,
http_scopes)
end
function _M.rewrite(plugin_conf, ctx)
- local conf = core.table.clone(plugin_conf)
+ local conf = fetch_secrets(plugin_conf)
Review Comment:
```suggestion
local conf = core.table.clone(plugin_conf)
local conf = fetch_secrets(plugin_conf)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
