darkSheep404 commented on code in PR #11451:
URL: https://github.com/apache/apisix/pull/11451#discussion_r1843132891
##########
apisix/plugins/openid-connect.lua:
##########
@@ -290,7 +291,8 @@ local _M = {
}
-function _M.check_schema(conf)
+function _M.check_schema(plugin_conf)
+ local conf = fetch_secrets(plugin_conf)
Review Comment:
So should we remove fetch_secrets from check_schema to avoid this?
By contrast, putting a Boolean value in a secret is not a particularly
common case in this plugin. Typically, only string urls and secret keys will be
placed in valut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
