shreemaan-abhishek commented on code in PR #12057:
URL: https://github.com/apache/apisix/pull/12057#discussion_r2004767545
##########
apisix/discovery/kubernetes/init.lua:
##########
@@ -571,6 +620,7 @@ local function multiple_mode_init(confs)
for _, item in pairs(ctx) do
start_fetch(item)
+ ngx.timer.every(1, update_token, item)
Review Comment:
running this timer every second doesn't sound like a good idea. Specially
given that the token expires in X days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]