nic-6443 commented on code in PR #12057:
URL: https://github.com/apache/apisix/pull/12057#discussion_r2009841918
##########
apisix/discovery/kubernetes/init.lua:
##########
@@ -324,23 +333,31 @@ local function get_apiserver(conf)
return nil, err
end
elseif conf.client.token_file and conf.client.token_file ~= "" then
- local file
- file, err = read_env(conf.client.token_file)
- if err then
- return nil, err
- end
+ setmetatable(apiserver, {
+ __index = function(_, key)
+ if key ~= "token" then
+ return nil
+ end
- apiserver.token, err = util.read_file(file)
- if err then
- return nil, err
- end
+ local token_file, err = read_env(conf.client.token_file)
+ if err then
+ core.log.error("failed to read token file path: ", err)
+ return nil
+ end
+
+ local token, err = read_token(token_file)
+ if err then
+ core.log.error("failed to read token from file: ", err)
+ return nil
+ end
+ core.log.debug("re-read the token value")
+ return token
+ end
+ })
else
return nil, "one of [client.token,client.token_file] should be set but
none"
end
- -- remove possible extra whitespace
Review Comment:
before this change, this line will trim token and token that read from token
file, now only token in file will be trim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
