hachi029 commented on code in PR #12048:
URL: https://github.com/apache/apisix/pull/12048#discussion_r2010185654


##########
apisix/plugin.lua:
##########
@@ -506,6 +506,16 @@ function _M.filter(ctx, conf, plugins, route_conf, phase)
             if plugin_conf._meta and plugin_conf._meta.priority then
                 custom_sort = true
             end
+

Review Comment:
   Ok. Is it better move  
   ```
           if plugins[i].type == "auth" then
               plugins[i + 1]._skip_rewrite_in_consumer = true
           end
   ```
   into _M.filter(...) ? because it is the function _M.filter determines or 
marks whether a plugin will be executed or not . 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to