nic-6443 commented on code in PR #12048:
URL: https://github.com/apache/apisix/pull/12048#discussion_r2011253938
##########
apisix/plugin.lua:
##########
@@ -506,6 +506,16 @@ function _M.filter(ctx, conf, plugins, route_conf, phase)
if plugin_conf._meta and plugin_conf._meta.priority then
custom_sort = true
end
+
Review Comment:
I found that there is a place where the `run_plugin` function is executed
without executing `filter` first:
https://github.com/apache/apisix/blob/52d8fea3dbc93c4b59ac6682902955c6146af4ad/apisix/init.lua#L437-L451
so I am not sure if moving it to `filter` will cause any issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
