darkSheep404 commented on code in PR #11451: URL: https://github.com/apache/apisix/pull/11451#discussion_r2221813253
########## apisix/plugins/openid-connect.lua: ########## @@ -554,7 +555,8 @@ local function validate_claims_in_oidcauth_response(resp, conf) end function _M.rewrite(plugin_conf, ctx) - local conf = core.table.clone(plugin_conf) + local conf_clone = core.table.clone(plugin_conf) Review Comment: > Referring to the code of other plugins, I think it can be modified with > > ``` > conf = fetch_secrets(conf, true, conf, "") > ``` > > The fetch_secrets function already handles deepcopy and cache. done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
