darkSheep404 commented on code in PR #11451: URL: https://github.com/apache/apisix/pull/11451#discussion_r2253344630
########## apisix/plugins/openid-connect.lua: ########## @@ -554,7 +555,7 @@ local function validate_claims_in_oidcauth_response(resp, conf) end function _M.rewrite(plugin_conf, ctx) - local conf = core.table.clone(plugin_conf) + local conf = fetch_secrets(plugin_conf, true, plugin_conf, "") Review Comment: > Please still clone the table. While it is true that `fetch_secrets` does imply this fact, it cannot be inferred from the name and is not a feature of any mandatory guarantee. As soon as someone modifies `fetch_secrets` in the future and doesn't clone there anymore, something will go wrong with your code. > > Therefore, it's best to explicitly copy this table here anyway to ensure that, no matter how much external conditions change, the logic of this plugin doesn't break. hi @Baoyuantop please advice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
