AlinsRan commented on code in PR #2560:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2560#discussion_r2354139338
##########
internal/adc/translator/apisixroute.go:
##########
@@ -40,6 +40,7 @@ import (
"github.com/apache/apisix-ingress-controller/internal/utils"
"github.com/apache/apisix-ingress-controller/pkg/id"
pkgutils "github.com/apache/apisix-ingress-controller/pkg/utils"
+ k8sTypes "github.com/apache/apisix-ingress-controller/internal/types"
Review Comment:
https://go.dev/doc/effective_go#package-names
The package name should be lowercase, and using the k8s prefix is not
appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
