CiriAllen commented on code in PR #2560: URL: https://github.com/apache/apisix-ingress-controller/pull/2560#discussion_r2357330688
########## api/adc/types.go: ########## @@ -393,11 +345,12 @@ const ( type Scheme string const ( - Grpc Scheme = "grpc" - Grpcs Scheme = "grpcs" - Kafka Scheme = "kafka" - TLS Scheme = "tls" - UDP Scheme = "udp" + Grpc Scheme = "grpc" + Grpcs Scheme = "grpcs" + Kafka Scheme = "kafka" + TLS Scheme = "tls" + UDP Scheme = "udp" + SchemeHTTP = "http" Review Comment: only reserve the 'SchemeHTTP' , because it is used in the code, and double checked that constants above is not used, so deleted them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
