Revolyssup commented on code in PR #12686:
URL: https://github.com/apache/apisix/pull/12686#discussion_r2464554153


##########
apisix/plugin.lua:
##########
@@ -1221,19 +1222,21 @@ function _M.run_plugin(phase, plugins, api_ctx)
         end
         return api_ctx, plugin_run
     end
-
+    tracer.new_span("apisix.phase." .. phase)

Review Comment:
   okay i changed the name



##########
apisix/core/response.lua:
##########
@@ -86,6 +89,9 @@ function resp_exit(code, ...)
     end
 
     if code then
+        if code >= 400 then
+            tracer.finish_current_span(tracer.status.ERROR, message or 
("response code " .. code))

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to