bzp2010 commented on code in PR #2647:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2647#discussion_r2532404963
##########
config/crd/bases/apisix.apache.org_gatewayproxies.yaml:
##########
@@ -150,6 +155,9 @@ spec:
type: object
x-kubernetes-validations:
- rule: has(self.endpoints) != has(self.service)
+ - message: mode is immutable
+ rule: oldSelf == null || (!has(self.mode) &&
!has(oldSelf.mode))
+ || self.mode == oldSelf.mode
Review Comment:
1. I understand that position.
However, please confirm: if I delete the GatewayProxy resource and recreate
it with the same name using a different mode, no resources will be deleted in
cascade, and the Ingress Controller will begin pushing configurations in the
new mode, correct?
Once you have confirmed the issue, I shall approve and merge it. We will
keep this restriction in place for the time being.
2. The cache will only exist on a single backend. It will not be shared
across different backend instances. This is not a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
