AlinsRan commented on code in PR #2647:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/2647#discussion_r2532452052


##########
config/crd/bases/apisix.apache.org_gatewayproxies.yaml:
##########
@@ -150,6 +155,9 @@ spec:
                     type: object
                     x-kubernetes-validations:
                     - rule: has(self.endpoints) != has(self.service)
+                    - message: mode is immutable
+                      rule: oldSelf == null || (!has(self.mode) && 
!has(oldSelf.mode))
+                        || self.mode == oldSelf.mode

Review Comment:
   1. Yes, when deleting GatewayProxy, it will only delete the association 
relationship, not the routing resources.
   
   
https://github.com/apache/apisix-ingress-controller/blob/6f0e78cfe8a702ef66fa8c448ee5381f8422e430/internal/controller/gatewayproxy_controller.go#L84-L91
   
   2. So the cache of ADC is distinguished by cache_key+type?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to