nic-6443 commented on code in PR #12800:
URL: https://github.com/apache/apisix/pull/12800#discussion_r2601506921
##########
apisix/plugin.lua:
##########
@@ -1273,22 +1329,26 @@ function _M.run_global_rules(api_ctx, global_rules,
phase_name)
api_ctx.global_rules = global_rules
end
+ local dummy_global_rule = merge_global_rule_lrucache(conf_version,
global_rules, merge_global_rules, global_rules)
+ if not dummy_global_rule then
+ core.log.error("failed to get merged global rules form cache,
using merge_global_rules instead")
+ dummy_global_rule = merge_global_rules(global_rules)
Review Comment:
This is unnecessary, lruchche will automatically execute
`merge_global_rules` when the request key does not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
