Baoyuantop commented on code in PR #3255:
URL: https://github.com/apache/apisix-dashboard/pull/3255#discussion_r2621961191
##########
src/apis/upstreams.ts:
##########
@@ -55,19 +55,56 @@ export const putUpstreamReq = (
};
export const deleteAllUpstreams = async (req: AxiosInstance) => {
- const totalRes = await getUpstreamListReq(req, {
- page: 1,
- page_size: PAGE_SIZE_MIN,
- });
+ // Retry wrapper to handle potential transient failures (e.g., 500 Internal
Server Error) when fetching upstream list.
+ // This is particularly useful in E2E tests where rapid creation/deletion
might cause temporary instability.
Review Comment:
I believe that testing should simulate real-world scenarios as closely as
possible, and we shouldn't rely on retries to guarantee a test pass.
##########
src/apis/stream_routes.ts:
##########
@@ -77,7 +77,14 @@ export const deleteAllStreamRoutes = async (req:
AxiosInstance) => {
page_size: PAGE_SIZE_MAX,
});
await Promise.all(
- res.list.map((d) => req.delete(`${API_STREAM_ROUTES}/${d.value.id}`))
+ res.list.map((d) =>
+ req.delete(`${API_STREAM_ROUTES}/${d.value.id}`).catch((err) => {
+ // Ignore 404 errors - resource already deleted
Review Comment:
Why is it necessary to add this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
