Baoyuantop commented on code in PR #3255:
URL: https://github.com/apache/apisix-dashboard/pull/3255#discussion_r2625793908
##########
src/apis/stream_routes.ts:
##########
@@ -77,7 +77,14 @@ export const deleteAllStreamRoutes = async (req:
AxiosInstance) => {
page_size: PAGE_SIZE_MAX,
});
await Promise.all(
- res.list.map((d) => req.delete(`${API_STREAM_ROUTES}/${d.value.id}`))
+ res.list.map((d) =>
+ req.delete(`${API_STREAM_ROUTES}/${d.value.id}`).catch((err) => {
+ // Ignore 404 errors - resource already deleted
Review Comment:
I don't think this is a good approach. Resources created by each test should
be independent; different tests shouldn't use the same resources.
When cleaning up resources, each test should only clean up the resources
created by that specific test, not all resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
