AlinsRan commented on code in PR #922:
URL: https://github.com/apache/apisix-helm-chart/pull/922#discussion_r2629232330
##########
charts/apisix/templates/service-gateway.yaml:
##########
@@ -50,7 +50,11 @@ spec:
{{- if .Values.service.http.enabled }}
- name: apisix-gateway
port: {{ .Values.service.http.servicePort }}
+ {{- if .Values.apisix.proxy_protocol.enabled }}
Review Comment:
It does not conflict with HTTP or HTTPS, why do we need to share a port?It
does not conflict with HTTP or HTTPS, we should add a new `service.port`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
