pantherra commented on code in PR #922:
URL: https://github.com/apache/apisix-helm-chart/pull/922#discussion_r2629605300


##########
charts/apisix/templates/service-gateway.yaml:
##########
@@ -50,7 +50,11 @@ spec:
   {{- if .Values.service.http.enabled }}
   - name: apisix-gateway
     port: {{ .Values.service.http.servicePort }}
+    {{- if .Values.apisix.proxy_protocol.enabled }}

Review Comment:
   Yes, it doesn't conflict. But when you enable proxy protocol on the network 
load balancer in front of the apache apisix (I'm using Oracle cloud) 
https://docs.nginx.com/nginx/admin-guide/load-balancer/using-proxy-protocol/
   From the documentation of the network load balancer:
   "For TCP applications using PROXY protocol v2, NLB adds a PROXY protocol v2 
header to each inbound TCP connection."
   So if you enable ppv2 on the nlb but your upstream (apisix) cannot accept 
ppv2 header in the tcp - then it will be rejected. That why we need to change 
default port on the service that exposes gateway to ports that support ppv2 tcp 
header.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to