shreemaan-abhishek commented on code in PR #12949: URL: https://github.com/apache/apisix/pull/12949#discussion_r2757562755
########## t/cli/test_standalone_docker.sh: ########## @@ -0,0 +1,216 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +. ./t/cli/common.sh + +standalone() { + clean_up + docker rm -f apisix-test-standalone 2>/dev/null || true + git checkout conf/apisix.yaml +} + +DOCKER_IMAGE="${DOCKER_IMAGE:-apache/apisix:master-debian-dev}" +trap standalone EXIT + +make build-on-debian-dev Review Comment: This is going to significantly increase the duration of the CI. We can take one of the following actions to avoid this: - use prebuilt image (image built from previous push) instead of building image while running the test. - run this test only on master branch - but this will require further more changes (e.g: a separate GitHub actions workflow) - and we won't be able to detect regressions before commit - run this test on a different GitHub actions workflow and only run them if any of the files related to this feature (ops.lua, docker-entrypoint.sh, etc) change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
