janiussyafiq commented on code in PR #12949: URL: https://github.com/apache/apisix/pull/12949#discussion_r2757581319
########## t/cli/test_standalone_docker.sh: ########## @@ -0,0 +1,216 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +. ./t/cli/common.sh + +standalone() { + clean_up + docker rm -f apisix-test-standalone 2>/dev/null || true + git checkout conf/apisix.yaml +} + +DOCKER_IMAGE="${DOCKER_IMAGE:-apache/apisix:master-debian-dev}" +trap standalone EXIT + +make build-on-debian-dev Review Comment: opt 1: won't work, i've discussed with @nic-6443, since the older image still rely on the script that is decided to be removed `check_standalone_config.sh`, so test will fail as for opt 2 and 3, can try those solution, i'm more leaning towards opt 3 wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
