Copilot commented on code in PR #3286: URL: https://github.com/apache/apisix-dashboard/pull/3286#discussion_r2911134923
########## e2e/tests/routes.vars-admin-api.spec.ts: ########## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import { routesPom } from '@e2e/pom/routes'; +import { e2eReq } from '@e2e/utils/req'; +import { test } from '@e2e/utils/test'; +import { expect } from '@playwright/test'; + +import { deleteAllRoutes, putRouteReq } from '@/apis/routes'; + +const routeId = 'test-vars-admin-api'; + +test.beforeAll(async () => { + await deleteAllRoutes(e2eReq); +}); Review Comment: This test calls `deleteAllRoutes` in both `beforeAll` and `afterAll`. With `fullyParallel: true` (and multiple workers locally), this can race with other e2e suites and delete routes they created, causing flaky failures. Prefer cleaning up only the specific route(s) created by this test (e.g., `DELETE /routes/{routeId}` if present), or otherwise isolate via a dedicated serial suite/worker-scoped namespace rather than wiping the entire resource type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
