DSingh0304 commented on PR #3286: URL: https://github.com/apache/apisix-dashboard/pull/3286#issuecomment-4107693310
> The fix direction (defensive filtering of non-string values in TagsInput) is correct, but there are a few issues to address: > > 1. **Unrelated changes**: The large diffs in `routeTree.gen.ts` and `apisix_conf.yml` are unrelated to this bug fix. Please revert them and handle separately if needed. > > 2. **CI status**: The current `mergeable_state` is unstable. Please ensure the latest commit passes all required checks. > > 3. **Silent data filtering risk**: TagInput silently drops non-string items, which could cause the UI to show fewer values than actually exist. Suggestions: > - At minimum, add a test to document this as expected behavior > - Better approach: add an observable warning (log or UI-level) when filtering occurs > > Please address these items for re-review. I will go through the comments and address each of them by today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
