coder2z commented on PR #12261: URL: https://github.com/apache/apisix/pull/12261#issuecomment-4764078736
> Hi @coder2z, thank you for tackling the WebSocket load balancing issue with least_conn!你好，感谢你用 least_conn 解决 WebSocket 负载均衡问题！ > > This is a real problem (39 comments show community engagement), but I have concerns about the PR scope:这确实是个问题（39条评论显示社区参与度），但我对公关范围有些担忧： > > 1. **Size and scope**: At 1878 lines across the balancer core, CLI, and schema, this PR is too large for safe review. Could you break it into smaller, incremental PRs? For example:**尺寸和范围 **：平衡器核心、CLI 和模式各有 1878 条线，该 PR 过大，无法安全审查。你能把它拆成更小的、渐进式的个人纪录吗？例如： > > * PR 1: Core balancer changes for WebSocket awarenessPR 1：核心平衡器改进以提升 WebSocket 认知 > * PR 2: CLI and configuration changesPR 2：CLI 与配置变更 > * PR 3: Schema updates and documentationPR 3：模式更新与文档 > 2. **Merge conflicts**: The PR is currently in a conflicting state. A rebase is needed.**合并冲突 **：波多黎各目前处于冲突状态。需要重新定基。 > 3. **Alternative approach**: Have you considered a simpler approach, such as adding a WebSocket-specific balancer option that tracks active connections rather than modifying the core least_conn algorithm?**替代方案 **：你是否考虑过更简单的方案，比如添加一个专门针对 WebSocket 的平衡器选项，追踪活跃连接，而不是修改核心 least_conn 算法？ > > I'd be happy to review smaller, focused PRs. The problem is worth solving, but the current change set is too risky to merge as a single unit. Thank you for your patience!我很乐意评测一些小型、聚焦的 PR 项目。这个问题值得解决，但当前的变更集合并为单一单位风险太大。感谢您的耐心等待！ Hey, sorry I haven't been able to address the review comments lately—just haven't had the bandwidth. But FYI, we've already got this running in our production environment and it's been stable. If possible, could you guys take this PR and clean it up to meet your standards? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
