coder2z commented on PR #12261: URL: https://github.com/apache/apisix/pull/12261#issuecomment-4764081328
> Hi @coder2z, thank you for tackling the WebSocket load balancing issue with least_conn! > > This is a real problem (39 comments show community engagement), but I have concerns about the PR scope: > > 1. **Size and scope**: At 1878 lines across the balancer core, CLI, and schema, this PR is too large for safe review. Could you break it into smaller, incremental PRs? For example: > > * PR 1: Core balancer changes for WebSocket awareness > * PR 2: CLI and configuration changes > * PR 3: Schema updates and documentation > 2. **Merge conflicts**: The PR is currently in a conflicting state. A rebase is needed. > 3. **Alternative approach**: Have you considered a simpler approach, such as adding a WebSocket-specific balancer option that tracks active connections rather than modifying the core least_conn algorithm? > > I'd be happy to review smaller, focused PRs. The problem is worth solving, but the current change set is too risky to merge as a single unit. Thank you for your patience! Hey, sorry I haven't been able to address the review comments lately—just haven't had the bandwidth. But FYI, we've already got this running in our production environment and it's been stable. If possible, could you guys take this PR and clean it up to meet your standards? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
