lxbme commented on code in PR #3435:
URL: https://github.com/apache/apisix-dashboard/pull/3435#discussion_r3635512439
##########
src/components/form-slice/FormPartSSL/index.tsx:
##########
@@ -54,12 +54,13 @@ const FormSectionClient = () => {
defaultValue={1}
min={0}
/>
- <InputWrapper label={t('form.ssls.client.skipMtlsUriRegex')}>
- <FormItemSwitch
- control={control}
- name="client.skip_mtls_uri_regex"
- />
- </InputWrapper>
+ {/* array<string> of URI regexes — a TagsInput, not a Switch:
+ the boolean broke this field both ways (#3417) */}
+ <FormItemTagsInput
Review Comment:
Fixed in e0850895 — `skip_mtls_uri_regex` now passes `splitChars={[]}`. The
round-trip e2e types `^/v[0-9]{1,3}$` with `pressSequentially` (so the comma
keystroke exercises the split path that `fill()` bypasses) and asserts it
survives as one tag through save.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
