lxbme commented on code in PR #3435:
URL: https://github.com/apache/apisix-dashboard/pull/3435#discussion_r3635513024
##########
src/components/form-slice/FormPartUpstream/FormSectionChecks.tsx:
##########
@@ -76,7 +75,10 @@ const FormSectionChecksActive = () => {
name={np('checks.active.http_path')}
label={t('form.upstreams.checks.active.http_path')}
/>
- <FormItemLabels
+ {/* array<string> of raw header lines — a TagsInput, not the Labels
+ widget (which produces an object and broke this field both ways,
+ #3417) */}
+ <FormItemTagsInput
Review Comment:
Fixed in e0850895 — `http_request_headers` now passes `splitChars={[]}`,
same as the regex field. The round-trip e2e types `Accept:
text/html,application/json` with `pressSequentially` and asserts it stays a
single entry through save.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
