Copilot commented on code in PR #13651:
URL: https://github.com/apache/apisix/pull/13651#discussion_r4026240747
##########
apisix/plugins/openid-connect.lua:
##########
@@ -294,7 +294,33 @@ local schema = {
description = "keepalive timeout in milliseconds",
},
}
- }
+ },
+ revocation = {
+ type = "string",
+ enum = {"redis"},
+ description = "Redis-backed revocation for cookie
sessions.",
+ },
+ revocation_fail_mode = {
+ type = "string",
+ enum = {"open", "closed"},
+ description =
+ "When the revocation store is unreachable, open treats
the "
+ .. "session as not revoked and closed rejects
open/destroy.",
+ },
+ revocation_cache_ttl = {
+ type = "integer",
+ minimum = 0,
Review Comment:
These two options are not supported by the pinned `lua-resty-session` 4.2.0
API: that release exposes `revocation` and `revocation_fail_mode`, but has no
`revocation_cache_ttl` or `revocation_error_cache_ttl` handling. Because
`build_session_opts` only passes this table through, APISIX accepts these
settings while the library silently ignores them, so the documented TTLs never
take effect. Please remove both options (and their docs/tests), or implement
the caching behavior before exposing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
