Hockenba commented on code in PR #13651:
URL: https://github.com/apache/apisix/pull/13651#discussion_r4026824931
##########
apisix/plugins/openid-connect.lua:
##########
@@ -294,7 +294,33 @@ local schema = {
description = "keepalive timeout in milliseconds",
},
}
- }
+ },
+ revocation = {
+ type = "string",
+ enum = {"redis"},
+ description = "Redis-backed revocation for cookie
sessions.",
+ },
+ revocation_fail_mode = {
+ type = "string",
+ enum = {"open", "closed"},
+ description =
+ "When the revocation store is unreachable, open treats
the "
+ .. "session as not revoked and closed rejects
open/destroy.",
+ },
+ revocation_cache_ttl = {
+ type = "integer",
+ minimum = 0,
+ description =
+ "Worker-local TTL in seconds for successful revocation
"
+ .. "lookups. 0 disables. Default is 5 in
lua-resty-session.",
+ },
+ revocation_error_cache_ttl = {
Review Comment:
Yes. Still feel free to take a peak at to make sure that I implemented what
was requested. :)
##########
apisix/plugins/openid-connect.lua:
##########
@@ -294,7 +294,33 @@ local schema = {
description = "keepalive timeout in milliseconds",
},
}
- }
+ },
+ revocation = {
+ type = "string",
+ enum = {"redis"},
+ description = "Redis-backed revocation for cookie
sessions.",
+ },
+ revocation_fail_mode = {
+ type = "string",
+ enum = {"open", "closed"},
+ description =
+ "When the revocation store is unreachable, open treats
the "
+ .. "session as not revoked and closed rejects
open/destroy.",
+ },
+ revocation_cache_ttl = {
+ type = "integer",
+ minimum = 0,
+ description =
+ "Worker-local TTL in seconds for successful revocation
"
+ .. "lookups. 0 disables. Default is 5 in
lua-resty-session.",
+ },
+ revocation_error_cache_ttl = {
Review Comment:
Yes. Still feel free to take a peak at to make sure that I implemented what
was requested :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
