willmafh commented on a change in pull request #2869:
URL: https://github.com/apache/apisix/pull/2869#discussion_r531433205
##########
File path: Makefile
##########
@@ -86,6 +86,8 @@ run: default
ifeq ("$(wildcard logs/nginx.pid)", "")
mkdir -p logs
$(OR_EXEC) -p $$PWD/ -c $$PWD/conf/nginx.conf
+else ifeq ("$(shell lsof -p $(shell cat logs/nginx.pid))", "")
+ $(OR_EXEC) -p $$PWD/ -c $$PWD/conf/nginx.conf
Review comment:
Actually we can't...The only thing we know for sure is nginx.pid exists
but there's no corresponding process...Also when a user executes `make run`,
**the implication** here is that he believes the apisix server is not running,
but if it does running, telling him that the server is running, just like the
way we do now...But if it doesn't, then we should just start the new server
process since the user doesn't care about it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
