willmafh commented on a change in pull request #2869:
URL: https://github.com/apache/apisix/pull/2869#discussion_r532158031
##########
File path: Makefile
##########
@@ -86,6 +86,8 @@ run: default
ifeq ("$(wildcard logs/nginx.pid)", "")
mkdir -p logs
$(OR_EXEC) -p $$PWD/ -c $$PWD/conf/nginx.conf
+else ifeq ("$(shell lsof -p $(shell cat logs/nginx.pid))", "")
+ $(OR_EXEC) -p $$PWD/ -c $$PWD/conf/nginx.conf
Review comment:
@spacewander I still don't think it's necessary to output some message
here...We can see
[bin/apisix](https://github.com/apache/apisix/blob/ce1d40b42f056f46b20386e1937fc81ba69e84c6/bin/apisix#L348)
start function, their logic are actually the same...If we really want to
output some message here, then the start function of bin/apisix should also be
changed, but it's really unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
