jenskeiner commented on a change in pull request #2903:
URL: https://github.com/apache/apisix/pull/2903#discussion_r533151959
##########
File path: apisix/plugins/openid-connect.lua
##########
@@ -82,63 +87,131 @@ function _M.check_schema(conf)
conf.logout_path = '/logout'
end
+ if not conf.set_access_token_header then
+ conf.set_access_token_header = true
+ end
+
+ if not conf.set_userinfo_token_header then
+ conf.set_userinfo_token_header = true
+ end
+
+ if not conf.set_id_token_header then
+ conf.set_id_token_header = true
+ end
+
+ if not conf.access_token_in_authorization_header then
+ conf.access_token_in_authorization_header = false
+ end
+
return true
end
-local function has_bearer_access_token(ctx)
+local function check_bearer_access_token(ctx)
+ -- Get Authorization header, maybe.
local auth_header = core.request.header(ctx, "Authorization")
if not auth_header then
- return false
+ -- No Authorization header, get X-Access-Token header, maybe.
+ local access_token_header = core.request.header(ctx, "X-Access-Token")
+ if not access_token_header then
+ -- No X-Access-Token header neither.
+ return false, nil, nil
+ end
+
+ -- Return extracted header value.
+ return true, access_token_header, nil
end
+ -- Check format of Authorization header.
local res, err = ngx_re.split(auth_header, " ", nil, nil, 2)
if not res then
- return false, err
+ return false, nil, err
end
- if res[1] == "bearer" then
- return true
+ if string.lower(res[1]) == "bearer" then
+ -- Return extracted token.
+ return true, res[2], nil
end
return false
end
+local function add_user_header(user)
+ local userinfo = core.json.encode(user)
+ ngx.req.set_header("X-Userinfo", ngx_encode_base64(userinfo))
+end
+
+
+local function add_access_token_header(ctx, conf, token)
+ -- Add Authorization or X-Access-Token header, respectively, if not
already set.
+ if conf.set_access_token_header then
+ if conf.access_token_in_authorization_header then
+ if not core.request.header(ctx, "Authorization") then
+ -- Add Authorization header.
+ ngx.req.set_header("Authorization", "Bearer " .. token)
+ end
+ else
+ if not core.request.header(ctx, "X-Access-Token") then
+ -- Add X-Access-Token header.
+ ngx.req.set_header("X-Access-Token", token)
+ end
+ end
+ end
+end
+
+
local function introspect(ctx, conf)
- if has_bearer_access_token(ctx) or conf.bearer_only then
+ -- Extract token, maybe. Ignore errors.
+ local has_token, token, _ = check_bearer_access_token(ctx)
+
+ -- Check if token was extracted or if we always require a token in the
request.
+ if has_token(ctx) or conf.bearer_only then
Review comment:
It's a bug, have pushed a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
