gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534041206



##########
File path: chart/apisix/values.yaml
##########
@@ -95,34 +102,51 @@ admin:
     admin: edd1c9f034335f136f87ad84b625c8f1
     viewer: 4054f7cf07e344346cd3f287985e76a2
 
+allow:
+  # The ip range for allowing access to Apache APISIX
+  ipList:
+    - 127.0.0.1/24
+
 # APISIX plugins to be enabled
 plugins:

Review comment:
       I keep it here is to leave a configuration item(placeholder) for users 
who wanted to use plugins belong themself.
    In fact, we can indeed set the plug-in list to be empty, I made it 
compatible.
   But I am not sure if we should set the plugin list empty by default?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to