gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r535036956



##########
File path: chart/apisix/templates/configmap.yaml
##########
@@ -72,9 +73,14 @@ data:
       #    disk_path: "/tmp/disk_cache_two"
       #    cache_levels: "1:2"
 
-    #  allow_admin:                  # 
http://nginx.org/en/docs/http/ngx_http_access_module.html#allow
-    #    - 127.0.0.0/24              # If we don't set any IP list, then any 
IP access is allowed by default.
-    #    - 172.17.0.0/24
+      allow_admin:                  # 
http://nginx.org/en/docs/http/ngx_http_access_module.html#allow

Review comment:
       Okay, we can do this config.yaml configuration in another issue #7 .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to