ShiningRush commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537549270
##########
File path: api/build.sh
##########
@@ -19,6 +19,9 @@ set -ex
export ENV=local
pwd=`pwd`
+VERSION=$(cat ./api/VERSION)
Review comment:
We also need go version, it is useful to debug problem, and if we add
the git version, it would be better to add branch name. and build date is also
useful.
You can refer
[here](https://github.com/m3db/m3/blob/master/scripts/go-build-ldflags.sh).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
