starsz commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537993157
##########
File path: api/build.sh
##########
@@ -19,6 +19,9 @@ set -ex
export ENV=local
pwd=`pwd`
+VERSION=$(cat ./api/VERSION)
Review comment:
I agree with add go version. But why are branch name and build date
useful, since we had git commit info.
In fact, I refer the
[mosn](https://github.com/mosn/mosn/blob/2adbcbc57994288fa4bdeb86bf43973443233a0b/Makefile#L94)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
