ShiningRush commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r537999422



##########
File path: api/main.go
##########
@@ -35,6 +35,16 @@ import (
        "github.com/apisix/manager-api/log"
 )
 
+var Version string
+
+func printInfo() {
+       fmt.Fprint(os.Stdout, "The manager-api is running successfully!\n\n")

Review comment:
       This is a different line with `listen on:`, this line dose not offer any 
helpful info to user.
   The original issue demo is just only one line `manager-api is running, and 
listen on: http://127.0.0.1:8080.`
   > And -v will be implemented at #773. Manager-api need a cli scafford.
   
   Got it, but I think it would be better have a discuss before coding, here 
are many projects implement the command just using native go `flag` library, 
are we really need that?  
   
   BTW: I think `manager-api is listen on : xxxx`  would be more simple,how do 
you think? @membphis @nic-chen 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to