gxthrj commented on a change in pull request #82:
URL:
https://github.com/apache/apisix-ingress-controller/pull/82#discussion_r541014434
##########
File path: cmd/ingress/ingress.go
##########
@@ -39,6 +41,15 @@ func dief(template string, args ...interface{}) {
os.Exit(1)
}
+func waitForSignal(stopCh chan struct{}) {
+ sigCh := make(chan os.Signal, 1)
+ signal.Notify(sigCh, syscall.SIGINT, syscall.SIGTERM)
Review comment:
It seems that I made a mistake.
`SIGABRT` could be sent manually by people to view the stack trace.
`SIGKILL ` will be sent by Kubernetes when container is still running after
the grace period.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]