gxthrj commented on a change in pull request #82:
URL:
https://github.com/apache/apisix-ingress-controller/pull/82#discussion_r541922937
##########
File path: cmd/ingress/ingress.go
##########
@@ -39,6 +41,15 @@ func dief(template string, args ...interface{}) {
os.Exit(1)
}
+func waitForSignal(stopCh chan struct{}) {
+ sigCh := make(chan os.Signal, 1)
+ signal.Notify(sigCh, syscall.SIGINT, syscall.SIGTERM)
Review comment:
> Behavior of SIGKILL cannot be changed, it's kernel's limitation.
Capture signals for logging, `SIGKILL` would be sent by Kubernetes. why not
to capture?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
